-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance system sc and p4est linkage #1231
Open
sandro-elsweijer
wants to merge
9
commits into
main
Choose a base branch
from
enhancement-system_sc_and_p4est_linkage_2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
23cee3a
indent
sandro-elsweijer 12f4be4
add a FindSC.cmake
sandro-elsweijer 1423c34
add a FindP4EST.cmake
sandro-elsweijer 86e1afe
indent
sandro-elsweijer fe8cb46
improve system sc and system p4est linkage
sandro-elsweijer 63f7189
enhance cmake linkage output
sandro-elsweijer 4f41f09
add newline at eof
sandro-elsweijer 6d59c9e
Merge branch 'main' into enhancement-system_sc_and_p4est_linkage_2
jmark 44277e6
Merge branch 'main' into enhancement-system_sc_and_p4est_linkage_2
jmark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# Once done, this will define | ||
# P4EST_FOUND - true if p4est has been found | ||
# P4EST_INCLUDE_DIR - the p4est include dir | ||
# P4EST_LIBRARIES - names of p4est libraries | ||
# P4EST_LINK_DIRECTORY - location of p4est libraries | ||
|
||
find_path(P4EST_INCLUDE_DIR p4est.h HINTS ${P4EST_ROOT}/../include PATH_SUFFIXES include) | ||
|
||
find_library(P4EST_LIBRARIES NAMES p4est HINTS ${P4EST_DIR}/../lib PATH_SUFFIXES lib) | ||
|
||
include(FindPackageHandleStandardArgs) | ||
find_package_handle_standard_args(P4EST DEFAULT_MSG P4EST_INCLUDE_DIR P4EST_LIBRARIES) | ||
|
||
if(NOT SC_LIBRARIES) | ||
message(FATAL_ERROR "p4est libraries not found") | ||
endif() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# Once done, this will define | ||
# SC_FOUND - true if SC has been found | ||
# SC_INCLUDE_DIR - the SC include dir | ||
# SC_LIBRARIES - names of SC libraries | ||
# SC_LINK_DIRECTORY - location of SC libraries | ||
|
||
find_path(SC_INCLUDE_DIR sc.h HINTS ${SC_DIR}/../include PATH_SUFFIXES include) | ||
|
||
find_library(SC_LIBRARIES NAMES sc HINTS ${SC_DIR}/../lib PATH_SUFFIXES lib) | ||
|
||
include(FindPackageHandleStandardArgs) | ||
find_package_handle_standard_args(SC DEFAULT_MSG SC_INCLUDE_DIR SC_LIBRARIES) | ||
|
||
if(NOT SC_LIBRARIES) | ||
message(FATAL_ERROR "SC libraries not found") | ||
endif() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be
if(NOT P4EST_LIBRARIES)
?