-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance system sc and p4est linkage #1231
base: main
Are you sure you want to change the base?
Conversation
@sandro-elsweijer The tests are failing for the CMake testsuite. |
include(FindPackageHandleStandardArgs) | ||
find_package_handle_standard_args(P4EST DEFAULT_MSG P4EST_INCLUDE_DIR P4EST_LIBRARIES) | ||
|
||
if(NOT SC_LIBRARIES) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be if(NOT P4EST_LIBRARIES)
?
As it currently stands, the system SC and P4est libraries include path are already taken into consideration. As using find_package in config mode retrieves the |
Describe your changes here:
Enhances the system SC and p4est linkage in such a way, that the include path is also found and linked to the executables.
Furthermore, the output of cmake is enhanced so that is easier to see if something has gone wrong during linkage of external modules.
All these boxes must be checked by the reviewers before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
The reviewer executed the new code features at least once and checked the results manually
The code follows the t8code coding guidelines
New source/header files are properly added to the Makefiles
The code is well documented
All function declarations, structs/classes and their members have a proper doxygen documentation
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)
Tests
Github action
The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)
All tests pass (in various configurations, this should be executed automatically in a github action)
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scp
to check the indentation of these files.Licence
doc/
(or already has one)