Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with vector as input #1059

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

Conversation

Prasanna-Ponnusamy
Copy link
Collaborator

Describe your changes here:
Modified the existing t8_gtest_ghost_exchange file to take std::vector as input.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

.vscode/settings.json Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how this tests the vector-conversion.
I propose to build a stdvector with standart data-types (int, double, ...), convert it to an sc_array and to compare its entries and other properties, such as length

src/t8_data/t8_stdvector_conversion.hxx Show resolved Hide resolved
src/t8_data/t8_stdvector_conversion.hxx Show resolved Hide resolved
src/t8_data/t8_stdvector_conversion.hxx Show resolved Hide resolved
src/t8_forest/t8_forest_partition.cxx Outdated Show resolved Hide resolved
@Davknapp
Copy link
Collaborator

Davknapp commented Jul 4, 2024

Can you indent the files and take care for the failing tests please?

Copy link
Collaborator

@Davknapp Davknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Please address my comments and also add your code to the CMake build system.

src/t8_data/t8_stdvector_conversion.hxx Outdated Show resolved Hide resolved
test/t8_forest/t8_gtest_ghost_exchange_stdvector.cxx Outdated Show resolved Hide resolved
test/t8_forest/stdvectortest.cxx Show resolved Hide resolved
@Davknapp Davknapp added priority: medium Should be solved within half a year workload: low Would take half a day or less enhancement Enhances already existing code C++ labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ enhancement Enhances already existing code priority: medium Should be solved within half a year workload: low Would take half a day or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide std::vector interfaces for our user data functions
3 participants