Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add julia wrapper for t8_cmesh_new_hypercube_pad_ext #72

Conversation

bennibolm
Copy link
Contributor

No description provided.

@JoshuaLampert
Copy link
Collaborator

I think we shouldn't add functions to src/Libt8.jl by hand. Why is this not part of the automatically generated code?

@bennibolm
Copy link
Contributor Author

Ah. Didn't know this part was automatically generated.

@JoshuaLampert
Copy link
Collaborator

Yes, src/Libt8.jl is generated in dev. I think t8_cmesh_new_hypercube_pad_ext is not yet included in the latest release v2.0.0 of t8code (released on April 19 2024), which t8code_jll.jl (and thus T8code.jl) is built on. The function was added after the last release on June 5. Thus, I think the correct way to deal with it, is to release a new version of t8code, rebuild t8code_jll.jl by adjusting the build script, run the generator.jl again, and push the changes to T8code.jl. Then t8_cmesh_new_hypercube_pad_ext should be there automatically. So the first step is a new release of t8code. What's the plan there, @jmark?

@bennibolm
Copy link
Contributor Author

Okay thanks 🙌 Then, I will close this PR again
I just discussed this with @jmark. Unfortunately, those releases still take some time.

@bennibolm bennibolm closed this Sep 18, 2024
@bennibolm bennibolm deleted the julia-wrapper-cmesh-new-hypercube-pad-ext branch September 18, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants