Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export @t8_replace_callback #62

Merged
merged 3 commits into from
Mar 20, 2024
Merged

export @t8_replace_callback #62

merged 3 commits into from
Mar 20, 2024

Conversation

ranocha
Copy link
Collaborator

@ranocha ranocha commented Mar 20, 2024

This macro is similar to the exported macro @t8_adapt_callback. Thus, I think it's useful to export it, too.

@JoshuaLampert
Copy link
Collaborator

Should these macros then also get some docstrings?

@ranocha
Copy link
Collaborator Author

ranocha commented Mar 20, 2024

Good idea - I added them

JoshuaLampert
JoshuaLampert approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaLampert JoshuaLampert merged commit cf22750 into main Mar 20, 2024
15 checks passed
@JoshuaLampert JoshuaLampert deleted the ranocha-patch-1 branch March 20, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaLampert JoshuaLampert JoshuaLampert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ranocha @JoshuaLampert