Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed wrongly typed "cmesh" argument. #49

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Fixed wrongly typed "cmesh" argument. #49

merged 1 commit into from
Jan 11, 2024

Conversation

jmark
Copy link
Contributor

@jmark jmark commented Jan 11, 2024

Closes #47

@jmark jmark added the fix Fixes a bug. label Jan 11, 2024
ranocha
ranocha approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you know why the wrong version was introduced - is there something wrong with the Clang generator?

@jmark
Copy link
Contributor Author

jmark commented Jan 11, 2024 •
edited
Loading

@ranocha I think this is a problem on t8code side. The associated header file
https://github.com/DLR-AMR/t8code/blob/main/src/t8_geometry/t8_geometry_with_vertices.h
does not include t8_cmesh.h where t8_cmesh_t is defined.

Instead of throwing an error Clang.jl seems to default to a Cint instead.

I'll fix this on the next t8code release.

@jmark jmark merged commit 4e3bfca into main Jan 11, 2024
13 checks passed
@jmark jmark deleted the fix-cmesh-ptr-as-int-argument branch January 11, 2024 11:44
@ranocha
Copy link
Collaborator

ranocha commented Jan 11, 2024

Great, thanks for investigating and fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranocha ranocha ranocha approved these changes

Assignees
No one assigned
Labels
fix Fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in v0.5
2 participants
@jmark @ranocha