Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoREST client #26

Closed
4 tasks done
chaen opened this issue Jun 29, 2023 · 3 comments
Closed
4 tasks done

AutoREST client #26

chaen opened this issue Jun 29, 2023 · 3 comments

Comments

@chaen
Copy link
Contributor

chaen commented Jun 29, 2023

@aldbr
Copy link
Contributor

aldbr commented Oct 5, 2023

How are we supposed to automatically update the autorest generated clients and use them?

I am thinking about a CI job that:

  • runs autorest --python and --typescript
  • generate a pip and an npm packages
  • update the client code in diracx (both python- and typescript-client would be located in this repo). This would be needed as we need to tweak the generated client. By the way, I haven't found any module similar to _patch.py in the autorest.typescript, which means that the patched client would be probably located in diracx-web.

diracx would import the python client, and diracx-web the typescript one.

Do you have another plan in mind?

@chaen
Copy link
Contributor Author

chaen commented Oct 17, 2024

I think this one can be closed.
We have the client working as we want for python, and the CI regenerates.
For the typescript part, I have no opinion as I haven't touched diracx-web. Do you feel the need for it yet ?

@aldbr
Copy link
Contributor

aldbr commented Oct 17, 2024

It might be interesting to get the models (e.g. Job fields, Status...).
In any case, I think this would probably be done in the diracx-web repo, not here.
I can open an issue in diracx-web to investigate this option at some point, and then we can close this particular issue I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants