-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for deploying non-demo chart #47
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisburr
force-pushed
the
chart-prod-improvements
branch
2 times, most recently
from
October 6, 2023 00:43
04eaa27
to
3e0ac69
Compare
chrisburr
force-pushed
the
chart-prod-improvements
branch
from
October 6, 2023 10:41
3e0ac69
to
56efbdb
Compare
chrisburr
force-pushed
the
chart-prod-improvements
branch
from
October 9, 2023 09:48
56efbdb
to
6645fe9
Compare
chrisburr
force-pushed
the
chart-prod-improvements
branch
2 times, most recently
from
October 9, 2023 16:09
1e63643
to
86854d4
Compare
chrisburr
force-pushed
the
chart-prod-improvements
branch
2 times, most recently
from
October 11, 2023 09:46
28153bf
to
8c87ad1
Compare
chrisburr
force-pushed
the
chart-prod-improvements
branch
from
October 11, 2023 10:51
8c87ad1
to
8fb4c27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change here is:
I chose this route based on researching various helm charts which can deploy fully featured applications and this seems like the most sensible approach. Most notably GitLab seems to do quite a nice job of providing everything in the helm chart and the documenting how to make it production suitable for various scenarios.
Some standardisation and clean up is needed but I think this is a enough for now. For example:
diracx-demo-init-sql
wait for the DB to be ready rather than failingvalues.yaml