Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for deploying non-demo chart #47

Merged
merged 16 commits into from
Oct 11, 2023

Conversation

chrisburr
Copy link
Member

@chrisburr chrisburr commented Oct 5, 2023

The main change here is:

  • Switch to using HTTPS for the demo
  • Use helm hooks + batch jobs to initialise the CS/DBs/secrets

I chose this route based on researching various helm charts which can deploy fully featured applications and this seems like the most sensible approach. Most notably GitLab seems to do quite a nice job of providing everything in the helm chart and the documenting how to make it production suitable for various scenarios.

Some standardisation and clean up is needed but I think this is a enough for now. For example:

  • Make diracx-demo-init-sql wait for the DB to be ready rather than failing
  • Harmonise the values.yaml
  • Use something like https://nip.io/ so we always have a host name
  • If we're using a custom CA and https://nip.io/ we could think about removing the use of node port
  • Figure out how to deploy to k3s
  • Move the ingress controller from the demo script to the helm chart

@chrisburr chrisburr requested a review from chaen October 5, 2023 19:24
@chrisburr chrisburr force-pushed the chart-prod-improvements branch 2 times, most recently from 04eaa27 to 3e0ac69 Compare October 6, 2023 00:43
@chrisburr chrisburr marked this pull request as ready for review October 9, 2023 09:53
@chrisburr chrisburr force-pushed the chart-prod-improvements branch 2 times, most recently from 1e63643 to 86854d4 Compare October 9, 2023 16:09
@chrisburr chrisburr force-pushed the chart-prod-improvements branch 2 times, most recently from 28153bf to 8c87ad1 Compare October 11, 2023 09:46
@chaen chaen merged commit 07d9590 into DIRACGrid:master Oct 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants