[9.0] Remove system instances #7671
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsareg
force-pushed
the
dev-remove-setup
branch
from
288e6b7
to
8bce932
Compare
4 tasks
fstagni
reviewed
Sep 19, 2024
| @@ -1100,44 +1094,6 @@ def do_revert(self, args): | |||
| else: | |||
| gLogger.notice("Software reverted to", result["Value"]) | |||
|
|
|||
| def do_add(self, args): | |||
There was a problem hiding this comment.
Why did you remove this entirely?
There was a problem hiding this comment.
This call is to add a system instance. The system instances elimination is the whole purpose of this PR. This call is no more relevant
|
The failed integration tests does not seem to be failing due to this PR changes. @fstagni : can you please have a look, may be you will have an idea for the failure reason ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the concept of system instances. The corresponding configuration options and sections are removed.
Requires #7186
BEGINRELEASENOTES
NEW: Remove the use of Setup and System Instances from the configuration and code
ENDRELEASENOTES