Refactoring HeaderSections #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts and containers)
|
@bicep let me take a look! ty! |
|
Yes that's great. I was working on MiningStatus and also reached a similar conclusion after getting more familiar with the code and this is a great step towards refactoring. Thanks! |
|
the headerSections.spec.js was broken because the RPC Server test was referencing the older file name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's not really working yet but I wanted to run the file structure with @debragail.
New files are added in the reducers, components and containers folders.
For the reducers and containers, each of the headersections have their own reducers and containers now. Got rid of the HeaderSection reducer.
For the components, there are now 4 new headersection components (HeaderSectionLastBlock, etc...), as well as the HeaderSection base class and the HeaderSections class that simply combines each of the 4 headersection components.
What do you think?
Related Issue
#149