Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Stratify notebook has some limitations when asked what states/parameters to stratify on #5510

Open
blanchco opened this issue Nov 14, 2024 · 0 comments
Labels
bug Something isn't working Q&A Quality Assurance

Comments

@blanchco
Copy link
Contributor

Describe the issue
The notebook doesn't seem to understand or provide the ability to not stratify parameters/states as eluded to in the test cases:

The example given:
Stratify my model by the locations Toronto, Montreal, Vancouver, Yellowknife where Montreal population can interact with Toronto population but not vice versa. Do not stratify the "I" state and "β" parameter.

model = stratify(
    template_model=model,
    key= "Location",
    strata=['Toronto', 'Montreal', 'Vancouver', 'Yellowknife'],
    structure= [['Montreal', 'Toronto']],
    directed=True, # Should the reverse direction conversions be added based on the given structure?
    cartesian_control=False,
    modify_names=True,
    concepts_to_stratify=None, 
    params_to_stratify=None, 
    concepts_to_preserve = ['I'],
    params_to_preserve = ['β'],
    param_renaming_uses_strata_names = True
)

I tried multiple times to run this but I do not get an code that includes the concepts_to_preserve or params_to_preserve keys
Image

@blanchco blanchco added bug Something isn't working Q&A Quality Assurance labels Nov 14, 2024
@blanchco blanchco changed the title [BUG]: Stratify notebook has some limitations on what states and parameters can stratify on [BUG]: Stratify notebook has some limitations when asked what states/parameters to stratify on Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Q&A Quality Assurance
Projects
None yet
Development

No branches or pull requests

1 participant