Skip to content
This repository has been archived by the owner on Feb 21, 2022. It is now read-only.

Errors in the API #194

Open
3 tasks
onmax opened this issue Mar 22, 2020 · 1 comment
Open
3 tasks

Errors in the API #194

onmax opened this issue Mar 22, 2020 · 1 comment
Assignees

Comments

@onmax
Copy link
Member

onmax commented Mar 22, 2020

This issue will contain all the errors that are found.

  • Companies object are not being returned correctly while displaying talks. Documentation for this enpoint can be found here
  • Speakers' social media is incorrect
  • Discuss about the key "image" or "picture"
    As an example:
    Current response
{
        "title": "Acto de Apertura",
        "start_date": "2020-03-16T10:00:00",
        "end_date": "2020-03-16T10:30:00",
        "description": "Se dará la bienvenida a los asistentes.",
        "url": "",
        "video": "",
        "company": "Delegación de Alumnos ETSI Informáticos, ETSIINF",
        "logo": null,
        "speakers": [
            {
                "name": "Álvaro Revuelta Martínez",
                "bio": "Delegado de Alumnos de la ETSI Informáticos durante los curso 2018-2019 y 2019-2020.\r\nColaborador en el Congreso Try IT! desde la edición 2017",
                "picture": "http://localhost:8000/media/speakers/photo_2019-12-10_00-13-20_SFgX0cV.jpg",
                "company": "ETSIINF",
                "personal_web": "",
                "twitter_profile": "https://twitter.com/aRevueltaM",
                "facebook_profile": "",
                "linkedin_profile": "https://www.linkedin.com/in/alvaro-revuelta/",
                "googleplus_profile": "",
                "github_profile": "",
                "gitlab_profile": ""
            }
        ],
        "track": ...,
        "rooms": "Salon de actos"
    },

Correct response (5 changes commented)

{
        "title": "Acto de Apertura",
        "id": 12345, // Id is not provided
        "start_date": "2020-03-16T10:00:00",
        "end_date": "2020-03-16T10:30:00",
        "description": "Se dará la bienvenida a los asistentes.",
        "url": "",
        "video": "",
        "logo": null,
         // company key here should be removed
        "speakers": [
            {
                "name": "Álvaro Revuelta Martínez",
                "bio": "Delegado de Alumnos de la ETSI Informáticos durante los curso 2018-2019 y 2019-2020.\r\nColaborador en el Congreso Try IT! desde la edición 2017",
                "picture": "http://localhost:8000/media/speakers/photo_2019-12-10_00-13-20_SFgX0cV.jpg",
                "company": { // Company should be an object
                    name: "Delegación de Alumnos ETSI Informáticos, ETSIINF",
                    logo: "path/to/logo",
                    url: "company.website",
                }
                "social_media": { // Add the social media key
                    "twitter_profile": "https://twitter.com/aRevueltaM",
                    "facebook_profile": "",
                    "linkedin_profile": "https://www.linkedin.com/in/alvaro-revuelta/",
                    "github_profile": "",
                    "gitlab_profile": ""
               }
                "personal_web": ""
            }
        ],
        "track": ...,
        "room": "Salon de actos" // Should be singular
    },
@onmax
Copy link
Member Author

onmax commented Mar 22, 2020

Please don't close this issue until full revision of the API is made

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants