-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScriptableObject + Cross-scene reference support #3
Draft
Cyanilux
wants to merge
8
commits into
master
Choose a base branch
from
cross-scene-reference-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ScriptableObject version of the ToDo list. Works identical to the MonoBehaviour version, just isn't attached to a Scene. Added ToDo lists to Create menus and "Cyan" heading to AddComponent menu Added SceneReferencesHandler which is automatically added to a scene when required. It's now possible to link objects to a task which are cross-scene, or scene-based on a prefab or ScriptableObject ToDo list. This has only been tested in 2020.1 currently. How it works : When dragging an object onto a task from a different scene, or from a scene when the ToDo list is a prefab/ScriptableObject, a SceneReferencesHandler object is created and added to the scene - hidden from the Hierarchy but still serialised in scene. The dragged object is registered with the handler, which assigns it a unique ID, adds it to a SerializableDictionary and saves the scene. The task can then reference and serialise the SceneAsset (in element.objectReference) and the ID (in element.objectReferenceID). When the task is visible in-editor, it will attempt to obtain the SceneReferenceHandler from the SceneAsset (if loaded, sidenote : won't work at runtime sadly, would need to save the scene name/path/buildIndex instead). With this it can obtain the object from the ID and show it in the object field. Fields which are serialised in this way are marked with a asterisk.
Fixed issue with reference handler not being marked dirty, so wasn't being saved. Thought Undo.RecordObject would handle it, but apparently it doesn't when using HideFlags to hide from hierarchy.
SceneReferenceHandler is now correctly serialised in 2018/2019 versions.
GameObject Create menu now shows as "To Do List (MonoBehaviour)" Asset Create menu now shows as "To Do List (ScriptableObject)"
Added UNITY_2019_2_OR_NEWER check for TryGetComponent usage in GetSceneReferencesHandler to prevent error in previous versions. Just uses GetComponent and null check instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has only been tested in 2020.1 currently.
How it works :
Known Issues :