Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static factory sugar for Java control requests #45

Open
Oblarg opened this issue Aug 18, 2023 · 0 comments
Open

Add static factory sugar for Java control requests #45

Oblarg opened this issue Aug 18, 2023 · 0 comments

Comments

@Oblarg
Copy link

Oblarg commented Aug 18, 2023

Instead of forcing users to manually call constructors with new, static factories wrapping the different control request types would improve readability:

motor.setControl(dutyCycle(1.0));

// compare to:
motor.setControl(new DutyCycleOut(1.0));

Implementation and maintenance cost for the static factories should be basically zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant