upgrade steps for the alert renaming #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VatsalJagani
requested changes
Sep 30, 2024
|
|
||
| logger.info("Re-enabled the product={}".format(product)) | ||
| except Exception: | ||
| logger.info("Error while product enable/disable. Please manually disable/enable the product on Cyences App Configuration > Product Setup page") |
There was a problem hiding this comment.
Add a warning or error message instead
Also add the exception message
| except Exception: | ||
| logger.info("Error while product enable/disable. Please manually disable/enable the product on Cyences App Configuration > Product Setup page") | ||
|
|
||
| alerts_to_disable = [ |
There was a problem hiding this comment.
Add comment on why we are doing this:
Removed alert might be present in apps/cyences_app_for_splunk/local/savedsearches.conf, which would constantly generate errors or run searches in all times, etc, etc. To avoid this we are disabling all these alerts if they present in the local folder.
VatsalJagani
approved these changes
Oct 3, 2024
hardikhdholariya
merged commit 0f5168c
into
upgrade-steps-for-release-5.0.0
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.