Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cp/lavanode #132

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Cp/lavanode #132

wants to merge 3 commits into from

Conversation

Codrin-Popa
Copy link
Contributor

No description provided.

@grant-m-s
Copy link
Contributor

I gave it a run and I don't think 'realistic' is the way we want to go. Everything in the game so far is blocky so having super smooth water/lava just seem very out of place. I think using an animated texture of lava on a plane will be our best option here.

@RcColes RcColes self-requested a review April 4, 2018 14:40
RcColes
RcColes requested changes Apr 4, 2018
View reviewed changes
Copy link
Contributor

@RcColes RcColes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring the aesthetic considerations, this also drops my FPS by 10-15, possibly due to the reflections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RcColes RcColes RcColes requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
archived
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Codrin-Popa @grant-m-s @RcColes