Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] MCCD interpolation #630

Open
martinkilbinger opened this issue May 30, 2023 · 1 comment
Open

[BUG] MCCD interpolation #630

martinkilbinger opened this issue May 30, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@martinkilbinger
Copy link
Contributor

When calling the function utils.shift_ker_stack in mccd.py, the kernel size lanc_rad is negative for three of the 1262 P3 CFIS tiles. This creates a numpy error. It seems that all PSF moments are -1, which is set as size in line mccd.py:1351.

This error should either be caught earlier, or the lanc_rad variable be set accordingly to a valid number.

@martinkilbinger martinkilbinger added the bug Something isn't working label May 30, 2023
@martinkilbinger martinkilbinger added this to the Re-run 2023 milestone May 30, 2023
@martinkilbinger martinkilbinger self-assigned this May 30, 2023
@martinkilbinger
Copy link
Contributor Author

After discussions with @tobias-liaudat this error is due to moments not being correctly estimated by galsim:HSM on certain images.
The variable lanc_rad is the interpolation radius to center the PSFs. In practise lanc_rad = 8 works well.
So an easy fix is to use this default if the input value is too small.

@tobias-liaudat will create a new MCCD version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants