-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to QtWebEngine #13
Comments
Yeah, we should move. Coding with QtWebEngine doesn't seem to be much different from QtWebkit.
Does this mean we can use their build scripts (again) ^^ ? I think the inveptor makes sense since a NodeOS (with GUI) can surely be a every day os ! |
I don't think so, main problem would be to compile it statically, but seems
No... but we can use them as reference about how to do the things, the same
Yes, but mostly because it's the most simple way to enable that |
So the guys from phantomjs have got a way to build it statically (?) AFAIK they only use QtWebkit... There's even a prototype for CEF but no one for QtWebEngine Haven't tried it on neither NodeOS nor noGui... |
PhantomJS provides a sonewhat statically linked binary. With PhantomJS 1
We should take a look of it on noGUI first... |
They still have QtWebkit in their Src dir (ariya/[email protected]) and their python build script points to QtWebkit too... Is ariya/phantomjs just the wrong repository ? |
So seems they didn't moved to QtWebEngine yet... :-/ We should consider to move ourselves then, but first let's release a version with QtWebkit first. |
Yeah, that's a bit sad :/... I'll look to continue noGUI ... Aurora is also faltering :/ |
Just as an information, I'll try to build a static QtWebEngine tonight, so fingers crossed ^^ |
Good luck! ;-) |
I followed this SO question As far as I can tell it worked. I'll try it again with qt5.7 in the next couple of days. |
That's cool! Can you show an output of the ldd command (and a screenshoot
|
Well I still have to get rid of xcb and build it for the Yeah, I'll do that. |
Get rid of xcb seems trivial, anyway left it by now just for testing. Add
|
I'll push them to an independent branch once I've written the scripts and adjusted the current noGUI code to the |
Fine! :-D Give me the ldd output please, I want to check it.
|
As soon as I 'm back at my computer ^^ |
ACK
|
Really bad news. The I built a shared version instead of the static version =/. However, it seems like it's possible to build it static since the build seems to fail at some "minor" errors only (or that's what it fail at now) People seem to have had the same problem in the past. However, the seem to have been able to fix it, so I'll try it again with the instructions on this thread. |
Ok. I can retake the claim that I built a static version, finally got it (I guess) |
Move to Qt WebEngine has been done :) |
Thanks ^^ |
@Coretool I suppose this issue can now be closed :D |
I've done some fixes on the build script and I'm compiling it just now to check if it works as expected so we can close this. On the other hand, we should check about the interceptor I told on the first comment before clossing this issue, or open a new one specific for it. |
@Technohacker, has you check your code compiles on a clean slate environment? What's your current system? I have been trying all the day to compile your changes to use QtWebEngine and it doesn't work statically, and with dynamic libraries it's asking me a lot more dependencies... |
Ok, the |
Definitely, this is not the way to go. Ideally QtWebEngine should be a good option, but I can't be able to replicate it. I've done a pull-request at #22 to see if you can check the fixes and try to find what's happening. Seems probably start from scratch with |
@piranna Sorry, I couldn't test with a static build of Qt because from my experience with Android, Chromium is a huge project to compile |
Then you should have adviced it...
El 19/6/2017 3:44, "K3v1n Kur14k053" <[email protected]> escribió:
… @piranna <https://github.com/piranna> Sorry, I couldn't test with a
static build of Qt because from my experience with Android, Chromium is a
huge project to compile
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAgfvpcgzrl1F3ojcrRZIJXitbQ1AosNks5sFdJ7gaJpZM4JUc3T>
.
|
Sorry, my mistake :[
…On Mon, Jun 19, 2017 at 11:01 AM Jesús Leganés-Combarro < ***@***.***> wrote:
Then you should have adviced it...
El 19/6/2017 3:44, "K3v1n Kur14k053" ***@***.***> escribió:
> @piranna <https://github.com/piranna> Sorry, I couldn't test with a
> static build of Qt because from my experience with Android, Chromium is a
> huge project to compile
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#13 (comment)>,
or mute
> the thread
> <
https://github.com/notifications/unsubscribe-auth/AAgfvpcgzrl1F3ojcrRZIJXitbQ1AosNks5sFdJ7gaJpZM4JUc3T
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ALG9LJZ1SNODAe6d3LhuoEy4W8YE3DmEks5sFgetgaJpZM4JUc3T>
.
|
I think we need to move to QtWebEngine... I tried to build
noGUI
the other day and it failed, and I'm not fully sure if it's due to usage of latest version of Qt whereQtWebkit
has been deprecated. On the other hand,QtWebEngine
has a full instance of Chromium that would give us a better compatibility and to work in pair with the latest PhantomJS, and also seems to be easy to add an interceptor that would allow us to remove the header that blocks the access to Google, Facebook, GitHub, StackOverflow and others from iframes if we find this is needed.The text was updated successfully, but these errors were encountered: