context menu to use screenshot instead of snapshot #3144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you renamed the variable, you'd also have to update the French i18n property file and who knows maybe some site already has a local i18n property file, so I'd leave the name as found. |
|
@kathryn-baker sorry I did not wait for the french fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #3143 to rename snapshot to screenshot in context menu.
Currently this just replaces the text in the context menu but doesn't change the variable name, is this sufficient?
I think I can see where I'd need to update the variable names as well but as I'm not a Java developer and those changes would be much more likely to break something it may require a more rigorous review / testing!