Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSTUDIO-2371 Open links to logbook-entries in the Logbook application and add "Back"- and "Forward"-buttons #3121

Merged
merged 21 commits into from
Aug 28, 2024

Conversation

abrahamwolk
Copy link
Collaborator

This pull request adds the following two features to the Logbook application:

  1. Links to other logbook entries are opened in the Logbook application itself, instead of opening them in an external browser. To determine whether a link is a link to another logbook entry, it is checked whether the link starts with LogbookUIPreferences.web_client_root_URL. If it does, the log entry ID is parsed from the link, and the logbook entry with the ID is loaded using LogClient.getLog().
  2. "Back" and "Forward" buttons are added to the Logbook application, in order to navigate back and forward, respectively. I have highlighted the "Back" and "Forward" buttons with a red rectangle in the following screenshot of the functionality:
    screenshot

…ryTable". Implement the selection of a new log entry using the functionality of this class.
…on whether there are log entries to go back or forward to, respectively.
…er.goBackAndGoForwardActions and make setting this field optional.
Copy link
Member

@shroffk shroffk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shroffk shroffk merged commit 54a414c into master Aug 28, 2024
2 checks passed
@abrahamwolk abrahamwolk deleted the CSSTUDIO-2371 branch August 29, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants