-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSSTUDIO-2371 Open links to logbook-entries in the Logbook application and add "Back"- and "Forward"-buttons #3121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…book entries in the Logbook application.
…ryTable". Implement the selection of a new log entry using the functionality of this class.
…g of "undoActions".
…rwardActions". Rename associated variables.
…o LogEntryDisplayController.
…on whether there are log entries to go back or forward to, respectively.
…ime to app-logbook-olog-ui.
…licks on log entries in the UI.
This reverts commit bca875f.
…er.goBackAndGoForwardActions and make setting this field optional.
shroffk
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the following two features to the Logbook application:
LogbookUIPreferences.web_client_root_URL
. If it does, the log entry ID is parsed from the link, and the logbook entry with the ID is loaded usingLogClient.getLog()
.