CSSTUDIO-2051 Replace SynchronousQueue with LinkedBlockingDeque in NamedDaemonPool
#3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta-structure LinkedBlockingDeque.
|
Closed this PR since the issue seems to be located elsewhere, as discovered by @georgweiss. I will attempt to implement a fix of the underlying issue and create a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the data-structure
SynchronousQueuewith the data-structureLinkedBlockingDequewhen callingnew ThreadPoolExecutor(...)in the classNamedDaemonPool.The motivation for this change is an observed performance increase: based purely on empirical testing, loading an OPI with on the order of 50 symbol widgets each with on the order of 10 different SVG files, the performance is dramatically improved when a
LinkedBlockingDequeis used instead of aSynchronousQueue. I have observed a performance increase both on Windows and on Linux. I have not tested the change on Mac OS.