CSSTUDIO-2412 Linear Meter bugfix: fix concurrency issue + improve performance #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues when the observed min- and max-values have actually changed.
…not previously [0, 100].
…n the JavaFX thread instead of using the "synchronized" keyword. This fixes a concurrency issue.
georgweiss
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a concurrency issue in the Linear Meter:
redrawIndicator()was called on different threads leading to exceptions being thrown. This PR changes the strategy for thread-safety: instead of using thesynchronizedkeyword, relevant parts of the code are always run on the JavaFX application thread using the new helper functionrunOnJavaFXThread().This PR also improves the performance of the Linear Meter widget in certain situations by avoiding unnecessary calls to
setRange().