Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Olog editing support #2737

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Olog editing support #2737

merged 3 commits into from
Jul 25, 2023

Conversation

shroffk
Copy link
Member

@shroffk shroffk commented Jul 18, 2023 •
edited
Loading

associated with accompanying changes to the Olog service in PR Olog/phoebus-olog#171

@georgweiss
Copy link
Collaborator

Looks good. Users will probably ask for an "Edit" button in the toolbar above the log entry details...

To consider:
When edited log entry has been submitted, the search result list should be refreshed to reflect changes (e.g. title, tags, logbooks). Same if the edited log entry is the one currently shown in the details view, otherwise user may question whether the entry was actually updated.

@shroffk
Copy link
Member Author

shroffk commented Jul 21, 2023

+1 on the auto refresh

@shroffk shroffk merged commit d0f7982 into master Jul 25, 2023
2 checks passed
@shroffk shroffk deleted the olog-editing-support branch September 11, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shroffk @georgweiss