Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf dependency update #2429

Merged
merged 3 commits into from
Nov 18, 2022
Merged

protobuf dependency update #2429

merged 3 commits into from
Nov 18, 2022

Conversation

georgweiss
Copy link
Collaborator

Turns out that a version update for protobuf might be sufficient. Basic testing does not show any errors, archiver data is retrieved as expected.

@shroffk
Copy link
Member

shroffk commented Nov 14, 2022

The update of the proto buffer dependency fails.
We are using the archiver appliance snapshot from 17-December-2021

@shroffk
Copy link
Member

shroffk commented Nov 14, 2022

currently, I do not see any error messages or logs on the client side.. it simply fails silently :(

@georgweiss
Copy link
Collaborator Author

georgweiss commented Nov 15, 2022

Sadly I now get the same disappointing result using this PR. However, rebuilding the pbrawclient jar against protobuf version 3.21.8 and using that updated jar in the project works for me. Probably had that updated jar in the project when I did my testing, sorry for missing out on that.

Suggest we close this PR for the time being and create a new when we can rely on a new pbrawclient from the "official" source. Issue ticket created: archiver-appliance/epicsarchiverap_pbrawclient#1

@shroffk
Copy link
Member

shroffk commented Nov 17, 2022

Ok,
I have this working too.
Using the prebuilt protoc binaries (for windows) I was able to rebuild the pbraw client and use it to retrieve pbraw data from our production archiver.
TODO: test with archived waveform pv's
@georgweiss we should update the phoebus dependencies to use the new client ( include the new jar in the install dependencies module )

@georgweiss
Copy link
Collaborator Author

As discussed: pbrawclient dependency updated to use a jar built against protobuf v3. Note however that the data types are still protobuf 2.

@shroffk
Copy link
Member

shroffk commented Nov 18, 2022

completed testing with waveform pv's too

@shroffk shroffk merged commit a758dbb into master Nov 18, 2022
@shroffk shroffk deleted the protobuf_upgrade_2 branch December 16, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants