Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose JFXRepresentation to other packages? #3069

Open
daykin opened this issue Jul 8, 2024 · 2 comments
Open

Expose JFXRepresentation to other packages? #3069

daykin opened this issue Jul 8, 2024 · 2 comments

Comments

@daykin
Copy link
Collaborator

daykin commented Jul 8, 2024

For the 'click heat-mapping' aspect of the UX analytics plugin, I need to know the Zoom level and boundaries of the JFXRepresentation of a display runtime in order to reconcile click events between clients that may have different sized and zoomed instances. The most trivial solution would be to change DisplayRuntimeInstance.getRepresentation() from package-private to public.

Alternatively, it might be safer from a compartmentalization perspective to only add a getZoom(), getCurrentHeight(), etc, but that is less flexible.

Which one would all of you Phoebus gurus suggest?

@kasemir
Copy link
Collaborator

kasemir commented Jul 11, 2024

Make the DisplayRuntimeInstance.getRepresentation() public, maybe with a comment that direct access to the JFX representation was allowed for special use cases like UX analytics. Display code should try to keep the separation of Model, Runtime and Representation which, in the original implementation, allowed swapping between an SWT and JFX representation.

@daykin
Copy link
Collaborator Author

daykin commented Jul 15, 2024

#3077 opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants