Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

Addition of the remaining methods which are in the Wallet Api #24

Open
aiinkiestism opened this issue Mar 12, 2023 · 2 comments
Open

Addition of the remaining methods which are in the Wallet Api #24

aiinkiestism opened this issue Mar 12, 2023 · 2 comments

Comments

@aiinkiestism
Copy link

Description
There's a few methods that are in the Wallet Api but not in this library.

I'm currently writing Dapp codes with React and on my way to refactor Wallet connection logic with this library, replacing Wallet Api with this library.
For now everything seems to be fine except above point. e.g. addCIS2Tokens

@bisgardo
Copy link
Contributor

bisgardo commented Mar 17, 2023

Hi @aiinkiestism, thanks for filing this issue.

The addCIS2Tokens and requestIdProof methods are not yet supported in the mobile wallets.

I think we should definitely add the methods to BrowserWalletConnector. If added to the WalletConector interface, the methods would have to throw "not implement" exceptions in WalletConnect. I think that's also reasonable, but will check with the team. We probably need a way for the dapp to probe whether a connector supports a given method.

For now, you can still access the browser wallet API directly via the client field in BrowserWalletConnector.

@bisgardo
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants