You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The type Web3IdCredential and others which contain the Value wrapper (which we use for secrets) are not Send.
This causes odd errors when attempting to use them in services. In particular they cannot be transferred through channels, e.g., tokio::sync::mpsc channel.
The reason for this is that underneath there is an Rc to avoid cloning the actual secret data, and just cloning the pointer to the data.
It would be more ergonomic if we changed the underlying wrapper to an Arc. These values are not cloned a lot, so there will be no observable performance impact.
The text was updated successfully, but these errors were encountered:
Description
The type
Web3IdCredential
and others which contain theValue
wrapper (which we use for secrets) are notSend
.This causes odd errors when attempting to use them in services. In particular they cannot be transferred through channels, e.g., tokio::sync::mpsc channel.
The reason for this is that underneath there is an
Rc
to avoid cloning the actual secret data, and just cloning the pointer to the data.It would be more ergonomic if we changed the underlying wrapper to an
Arc
. These values are not cloned a lot, so there will be no observable performance impact.The text was updated successfully, but these errors were encountered: