Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain sort upon packet signature #291

Open
adamhb123 opened this issue Aug 24, 2021 · 2 comments
Open

Maintain sort upon packet signature #291

adamhb123 opened this issue Aug 24, 2021 · 2 comments

Comments

@adamhb123
Copy link
Member

After signing a packet, the entire page is refreshed and any sorting you had chosen (i.e. by signature count) is undone. Not doing that would be pretty cash money.

@adamhb123 adamhb123 changed the title Maintain sort upon package signature Maintain sort upon packet signature Aug 24, 2021
@mxmeinhold
Copy link
Collaborator

Hmm, how are you thinking you might handle this?

@adamhb123
Copy link
Member Author

adamhb123 commented Aug 24, 2021

I might not personally work on it for a few weeks or so. Pretty backlogged on other stuff (documenting nuinfosys, adding an api to it, getting it ready to be published publicly, etc). It could be fed to the template already sorted or could be just sorted within the template using Jinja2's sort function, but then we would need to pass a variable to the template describing how the list should be sorted, which pretty much defeats the purpose. I haven't even looked at the code so I have no firm suggestions as of right now.

My knee-jerk reaction was that it probably wouldn't be that hard so I labelled it as a good first issue. If you don't think so feel free to remove it of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants