Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images arent always displayed in the correct orientation when viewing an image #60

Open
MoralCode opened this issue Oct 17, 2019 · 1 comment

Comments

@MoralCode
Copy link

MoralCode commented Oct 17, 2019

When viewing images taken vertically (i.e. https://gallery.csh.rit.edu/view/file/36582), some browsers (i.e. new versions of firefox) correctly rotate the image based on its EXIF metadata, however, most browsers (i.e. chromium) still display it incorrectly.

in order to fix this for other browsers, there needs to be a fallback for when the image-orientation CSS property is not supported.

So far i've come up with:

  1. Since Thumbnail Rotation #45 seems to be rotating thumbnails server-side, maybe we could also rotate the images server-side before displaying them, however, it seems like the /api/files/get endpoint is just returning a link to s3, so this might be a pretty complicated way to do it.
  2. alternatively, maybe we could implement the rotation using CSS classes and have the view_file.html template look at the metadata and decide which to use
@RamZallan
Copy link
Member

IMO we should handle things server-side, specifically on upload, fixing both thumbnail and file orientation. Probably best to do it on the /upload POST

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants