Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Event System #70

Open
liam-middlebrook opened this issue Jul 3, 2017 · 1 comment
Open

Rework Event System #70

liam-middlebrook opened this issue Jul 3, 2017 · 1 comment

Comments

@liam-middlebrook
Copy link
Member

Considering reworking the event system to write events to a named pipe and then creating another application for polling these events. This would fix the issue where once the gravestone is displayed the game locks up for a moment while the event is processed.

@eatnumber1 what's your opinion on this? Would it be better to just fix the issue given the current fork+exec structure of the system?

@eatnumber1
Copy link
Member

Adding a pipe won't remove the blocking writes to it. You can fix the lock-up issue by using non-blocking sockets, which you'll need to do with or without a named pipe.

FWIW, I think there's value in "not fixing what's not broke". Also properly passing complex state (e.g. errors) between process boundaries is non-trivial.

That said, the one real potential for value here is if you can convince upstream to accept patches for publishing events, they're more likely to accept something that just writes to a file than something that writes to a db or random multicast address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants