Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to sets for storing species constants in PyPIConGPU #5023

Open
BrianMarre opened this issue Aug 8, 2024 · 0 comments
Open

Switch to sets for storing species constants in PyPIConGPU #5023

BrianMarre opened this issue Aug 8, 2024 · 0 comments
Assignees
@BrianMarre
Labels
good first issue signal new contributors where they can start PICMI pypicongpu and picmi related refactoring code change to improve performance or to unify a concept but does not change public API

Comments

@BrianMarre
Copy link
Member

BrianMarre commented Aug 8, 2024 •
edited
Loading

Currently species constants are stored in a list in PyPIConGPU, but semantically they more resemble elements of a set since constant types are supposed to be unique for a species.
Switching to sets also would allow the removal of code as discussed here
@steindev steindev added refactoring code change to improve performance or to unify a concept but does not change public API component: user input signals changes in user API such as .param files, .cfg syntax, etc. - changelog! good first issue signal new contributors where they can start PICMI pypicongpu and picmi related and removed component: user input signals changes in user API such as .param files, .cfg syntax, etc. - changelog! labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrianMarre BrianMarre

Labels
good first issue signal new contributors where they can start PICMI pypicongpu and picmi related refactoring code change to improve performance or to unify a concept but does not change public API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steindev @BrianMarre