Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overly long relative imports in PICMI/PyPIConGPU #5012

Open
BrianMarre opened this issue Jul 31, 2024 · 0 comments
Open

Overly long relative imports in PICMI/PyPIConGPU #5012

BrianMarre opened this issue Jul 31, 2024 · 0 comments
Assignees
@BrianMarre
Labels
good first issue signal new contributors where they can start PICMI pypicongpu and picmi related refactoring code change to improve performance or to unify a concept but does not change public API

Comments

@BrianMarre
Copy link
Member

Both the PIConGPU PICMI interface and PyPIConGPU use relative imports, which mean when we import pypicongpu stuff from PICMI we need to traverse a lot of directory levels leading to a lot of dots.

This could be potentially avoided by making pypicongpu directly accessible as a separate module.
@BrianMarre BrianMarre mentioned this issue Jul 31, 2024
Merged
4 tasks
@steindev steindev added refactoring code change to improve performance or to unify a concept but does not change public API good first issue signal new contributors where they can start PICMI pypicongpu and picmi related labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrianMarre BrianMarre

Labels
good first issue signal new contributors where they can start PICMI pypicongpu and picmi related refactoring code change to improve performance or to unify a concept but does not change public API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steindev @BrianMarre