Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor renderer.py #4822

Open
chillenzer opened this issue Feb 20, 2024 · 0 comments
Open

Refactor renderer.py #4822

chillenzer opened this issue Feb 20, 2024 · 0 comments
Assignees
Labels
component: tools scripts, python libs and CMake

Comments

@chillenzer
Copy link
Contributor

During the work on #4817, some peculiarities of lib/python/picongpu/pypicongpu/rendering/renderer.py (and potentially other such files) popped up like the seemingly overly restrictive type guarding going against the idea of inheritance and duck typing. @BrianMarre and I agreed that it might be a good idea to refactor that into a more robust version. I think this should reasonably put onto the agenda when that file is touched the next time, so this issue is not immediately actionable, but if someone has time to go ahead with it...

@steindev steindev added the component: tools scripts, python libs and CMake label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tools scripts, python libs and CMake
Projects
None yet
Development

No branches or pull requests

2 participants