Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brokers on the whitelist can be removed #9

Open
4 tasks done
patriacaelum opened this issue Nov 3, 2021 · 0 comments
Open
4 tasks done

Brokers on the whitelist can be removed #9

patriacaelum opened this issue Nov 3, 2021 · 0 comments

Comments

@patriacaelum
Copy link

patriacaelum commented Nov 3, 2021

At the moment, the WhitelistMechanism is designed to be a one way system. Once brokers are whitelisted, they stay there permanently. When a vote for a broker is changed, this may affect a broker's whitelist status.

However, this means that a broker that is already committed to a proposal may be removed from the whitelist, but still remain a broker on the proposal. Whether or not the broker should be immediately removed from the proposal is an open question.

  • Keep past voting information in the WhitelistMechanism
  • Add a remove_from_whitelist method
  • When a voter votes, consider what happens if the broker is already in the whitelist. If the minimum condition is not longer met, then the broker is removed from the whitelist and added back to the waitlist
  • Add removing unit tests
patriacaelum referenced this issue in longtailfinancial/proposal-inverter Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant