From 6261b299a8c0a2ce935ce399eca163d77fab9545 Mon Sep 17 00:00:00 2001 From: Jason L Weirather Date: Tue, 17 Sep 2024 13:12:00 -0400 Subject: [PATCH] instead of fail gracefully, pass a warning through logging. by logging default settings this warning should be displayed --- comfy_cli/update.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/comfy_cli/update.py b/comfy_cli/update.py index b7d2a19..4ca126c 100644 --- a/comfy_cli/update.py +++ b/comfy_cli/update.py @@ -1,4 +1,5 @@ import sys +import logging from importlib.metadata import metadata import requests @@ -6,6 +7,9 @@ from rich.console import Console from rich.panel import Panel +# Set up a logger for the module +logger = logging.getLogger(__name__) + console = Console() @@ -29,8 +33,9 @@ def check_for_newer_pypi_version(package_name: str, current_version: str, timeou return True, latest_version return False, current_version - except requests.RequestException: - # Fail quietly on timeout or any request exception + except requests.RequestException as e: + logger.warning(f"Unable to fetch {package_name} version metadata from PyPI. Retaining current version {current_version}. " + f"Exception: {type(e).__name__} - {e}") return False, current_version