Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group node naming compatibility #969

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Fix group node naming compatibility #969

merged 3 commits into from
Sep 25, 2024

Conversation

christian-byrne
Copy link
Collaborator

#950 changed group node names' prefix from workflow/ to workflow>. To be compatible with older workflows, change workflow/ to workflow> in graph data when configuring.

Issue:

@huchenlei huchenlei merged commit 84fc0e9 into main Sep 25, 2024
9 checks passed
@huchenlei huchenlei deleted the legacy-groupnodes branch September 25, 2024 06:25
@mijuku233
Copy link
Contributor

Strange, this PR seems to be to fix the bug that the group node in the workflow cannot be loaded?
But in fact, when using the 1.2.64 front end, no matter how the workflow is saved, the group node in it cannot be loaded by any version of the front end.

image

@christian-byrne
Copy link
Collaborator Author

Strange, this PR seems to be to fix the bug that the group node in the workflow cannot be loaded? But in fact, when using the 1.2.64 front end, no matter how the workflow is saved, the group node in it cannot be loaded by any version of the front end.

Thank you for reporting it.

Does it work when you disable ComfyUI-Manager? And can you share the workflow?

@mijuku233
Copy link
Contributor

Workflows with group nodes can be saved normally when ComfyUI-Manager is disabled.
This is a simple test workflow (ComfyUI-Manager is not disabled).
test.json

@christian-byrne
Copy link
Collaborator Author

Just pushed a fix ltdrdata/ComfyUI-Manager#1084

@mijuku233
Copy link
Contributor

Just pushed a fix ltdrdata/ComfyUI-Manager#1084

Thanks for fixing it, there is another bug about "manager and group node" ltdrdata/ComfyUI-Manager#1080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants