Reduce SearchBox margins for lower resolutions. #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
approved these changes
Sep 24, 2024
|
I just rebased |
On lower screen widths, the SearchBox would scale itself down instead of reducing the fairly wide margins. This wastes space and has reduces the usability of the search box contents itself by cutting off information (such as the experimental badge) on nodes with medium or longer titles This is not without side effects, so further adjustments may be needed. Currently, the searchbox is slightly offset to the right even for wide screens and the adjustments are disabled for very small screens (<=768) such that the preview is offscreen, but the entirety of the searchbox is properly displayed down to 512
AustinMroz
force-pushed
the
searchbox-margins
branch
from
ace831e
to
d4a7c57
Compare
huchenlei
pushed a commit
that referenced
this pull request
Sep 25, 2024
On lower screen widths, the SearchBox would scale itself down instead of reducing the fairly wide margins. This wastes space and has reduces the usability of the search box contents itself by cutting off information (such as the experimental badge) on nodes with medium or longer titles This is not without side effects, so further adjustments may be needed. Currently, the searchbox is slightly offset to the right even for wide screens and the adjustments are disabled for very small screens (<=768) such that the preview is offscreen, but the entirety of the searchbox is properly displayed down to 512
huchenlei
pushed a commit
that referenced
this pull request
Sep 25, 2024
On lower screen widths, the SearchBox would scale itself down instead of reducing the fairly wide margins. This wastes space and has reduces the usability of the search box contents itself by cutting off information (such as the experimental badge) on nodes with medium or longer titles This is not without side effects, so further adjustments may be needed. Currently, the searchbox is slightly offset to the right even for wide screens and the adjustments are disabled for very small screens (<=768) such that the preview is offscreen, but the entirety of the searchbox is properly displayed down to 512
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On lower screen widths, the SearchBox would scale itself down instead of reducing the fairly wide margins. This wastes space and reduces the usability of the search box itself by cutting off information (such as the experimental badge) on nodes with medium or longer titles
This is not without side effects, so further adjustments may be needed. Currently, the searchbox is slightly offset to the right even for normal screen width. Additionally, the adjustment is disabled for very small screen widths (<=768) such that the preview is offscreen, but the entirety of the searchbox is properly displayed down to 512.