Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execution Error Dialog Revamp (One click issue searching and filing) #595

Merged
merged 10 commits into from
Aug 22, 2024
Merged

Execution Error Dialog Revamp (One click issue searching and filing) #595

merged 10 commits into from
Aug 22, 2024

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Aug 22, 2024 •
edited
Loading

Closes #344

Note

  • More information like comfyui version (Git hash), custom nodes installed, command line args will need to be made available via API first. After these backend changes, we will make them available in the frontend.
  • The execution error is only the error that reported from python backend about workflow execution failure.
oneClickFileIssue.mp4

@socket-security Socket Security
Copy link

socket-security bot commented Aug 22, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] network Transitive: environment, filesystem +8 2.49 MB jasonsaayman

View full report↗︎

@huchenlei huchenlei merged commit 3e457f8 into Comfy-Org:main Aug 22, 2024
4 checks passed
@huchenlei huchenlei deleted the errorDialog branch August 22, 2024 19:55
@melMass
Copy link

melMass commented Aug 22, 2024

Beautiful! Thanks for all the work ♥️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Error Dialog overflow issues
2 participants
@huchenlei @melMass