Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Workflows not opening in new tabs #995

Closed
LukeG89 opened this issue Sep 26, 2024 · 3 comments
Closed

[Bug]: Workflows not opening in new tabs #995

LukeG89 opened this issue Sep 26, 2024 · 3 comments
Labels
Potential Bug Untriaged bug

Comments

@LukeG89
Copy link

LukeG89 commented Sep 26, 2024

Frontend Version

1.3.1

Expected Behavior

As shown in this merged pull request #952, workflows should now open in new tabs.

Actual Behavior

Workflows open in the same window as before.

Steps to Reproduce

opened_workflows

Debug Logs

E:\>.\python_embeded\python.exe -s ComfyUI\main.py --windows-standalone-build --disable-all-custom-nodes --preview-size 1024 --front-end-version Comfy-Org/ComfyUI_frontend@latest
Total VRAM 8192 MB, total RAM 65277 MB
pytorch version: 2.4.1+cu124
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 3070 Ti Laptop GPU : cudaMallocAsync
Using pytorch cross attention
[Prompt Server] web root: E:\ComfyUI\web_custom_versions\Comfy-Org_ComfyUI_frontend\1.3.1
E:\python_embeded\Lib\site-packages\kornia\feature\lightglue.py:44: FutureWarning: `torch.cuda.amp.custom_fwd(args...)` is deprecated. Please use `torch.amp.custom_fwd(args..., device_type='cuda')` instead.
  @torch.cuda.amp.custom_fwd(cast_inputs=torch.float32)
Skipping loading of custom nodes
Starting server

To see the GUI go to: http://127.0.0.1:8188

Browser Logs

Running on 127.0.0.1:8188
logging.ts:331 ComfyUI Front-end version: 1.3.1

What browsers do you use to access the UI ?

Google Chrome

Other

No response

@LukeG89 LukeG89 added the Potential Bug Untriaged bug label Sep 26, 2024
@mcmonkey4eva
Copy link
Member

This is not a bug, that feature was intentionally hidden in PR #984
It's possible to manually edit (ComfyUI)/user/default/comfy.settings.json to have "Comfy.Workflow.WorkflowTabsPosition": "Topbar" to get access to this behavior.

I'm not sure why it's hidden though? @huchenlei

@LukeG89
Copy link
Author

LukeG89 commented Sep 26, 2024

Sorry, I didn't catch that! Thank you @mcmonkey4eva!

@LukeG89 LukeG89 closed this as completed Sep 26, 2024
@huchenlei
Copy link
Member

This is not a bug, that feature was intentionally hidden in PR #984 It's possible to manually edit (ComfyUI)/user/default/comfy.settings.json to have "Comfy.Workflow.WorkflowTabsPosition": "Topbar" to get access to this behavior.

I'm not sure why it's hidden though? @huchenlei

It was a decision from @yoland68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug Untriaged bug
Projects
None yet
Development

No branches or pull requests

3 participants