Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling previews breaks audio node widgets #141

Closed
christian-byrne opened this issue Jul 17, 2024 · 1 comment · Fixed by #168
Closed

Enabling previews breaks audio node widgets #141

christian-byrne opened this issue Jul 17, 2024 · 1 comment · Fixed by #168
Labels
bug Something isn't working

Comments

@christian-byrne
Copy link
Collaborator

Selection_051

Audio nodes are trying to get previews:

function getResourceURL(
subfolder: string,
filename: string,
type: FolderType = "input"
): string {
const params = [
"filename=" + encodeURIComponent(filename),
"type=" + type,
"subfolder=" + subfolder,
app.getPreviewFormatParam().substring(1),
app.getRandParam().substring(1),
].join("&");
return `/view?${params}`;
}

Previews don't seem to be implemented for audio yet.

Terminal output:

Traceback (most recent call last):
  File "/home/c_byrne/projects/comfy-testing-environment/venv/lib/python3.11/site-packages/aiohttp/web_protocol.py", line 452, in _handle_request
    resp = await request_handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/c_byrne/projects/comfy-testing-environment/venv/lib/python3.11/site-packages/aiohttp/web_app.py", line 543, in _handle
    resp = await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/c_byrne/projects/comfy-testing-environment/venv/lib/python3.11/site-packages/aiohttp/web_middlewares.py", line 114, in impl
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/c_byrne/projects/comfy-testing-environment/ComfyUI/server.py", line 43, in cache_control
    response: web.Response = await handler(request)
                             ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/c_byrne/projects/comfy-testing-environment/ComfyUI/server.py", line 296, in view_image
    with Image.open(file) as img:
         ^^^^^^^^^^^^^^^^
  File "/home/c_byrne/projects/comfy-testing-environment/venv/lib/python3.11/site-packages/PIL/Image.py", line 3339, in open
    raise UnidentifiedImageError(msg)
PIL.UnidentifiedImageError: cannot identify image file '/home/c_byrne/projects/comfy-testing-environment/ComfyUI/temp/ComfyUI_temp_tafpy_00002_.flac'
@christian-byrne
Copy link
Collaborator Author

Was fixed by comfyanonymous/ComfyUI#4044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants