Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce responsibilities of the StateTransitionManager #20

Open
redeboer opened this issue Sep 23, 2020 · 0 comments
Open

Reduce responsibilities of the StateTransitionManager #20

redeboer opened this issue Sep 23, 2020 · 0 comments
Assignees
@grayson-helmholz
Labels
Epic Collection of issues ⚠️ Interface Breaking changes to the API

Comments

@redeboer
Copy link
Member

redeboer commented Sep 23, 2020 •
edited
Loading

The StateTransitionManager is supposed to serve as a facade to the expertsystem, but many of its methods (such as _determine_node_settings) perform quite a lot of tasks. That raises the question whether they shouldn't become functions elsewhere, so that the StateTransitionManager can be made smaller.

This issue has become related to ComPWA/expertsystem#314 / ComPWA/expertsystem#196.

  • The reaction.combinatorics function can take more of the responsibilities that the StateTransitionManager performs. It is currently rather empty and it's unclear why it's a separate module.
  • The StateTransitionManager can be stripped of its amplitude creation functionality and put directly under reaction. Some higher-level facades can then provide the functions that are needed for the quickstart.
@redeboer redeboer transferred this issue from ComPWA/expertsystem Apr 6, 2021
@redeboer redeboer added ⚠️ Interface Breaking changes to the API 🔨 Maintenance Maintenance and upkeep improvements Epic Collection of issues labels Apr 16, 2021
@redeboer redeboer mentioned this issue Sep 8, 2021
Closed
redeboer added a commit to redeboer/ComPWA-qrules that referenced this issue Apr 30, 2022
@redeboer
docs: add description to main module (ComPWA#20)
7d7c3d2 
* chore: remove graphvis
* docs: improve description expertsystem module
* docs: fix link to contribute page
@redeboer redeboer mentioned this issue May 6, 2024
Open
@redeboer redeboer mentioned this issue Jun 26, 2024
Closed
@redeboer redeboer changed the title Reduce responsibilities of the StateTransitionManager Reduce responsibilities of the StateTransitionManager Aug 26, 2024
@redeboer redeboer mentioned this issue Aug 26, 2024
Open
@redeboer redeboer removed the 🔨 Maintenance Maintenance and upkeep improvements label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grayson-helmholz grayson-helmholz

Labels
Epic Collection of issues ⚠️ Interface Breaking changes to the API
Projects
Student projects
Status: 🆕 Icebox
Milestone
No milestone
Development

No branches or pull requests
2 participants
@redeboer @grayson-helmholz