Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: add reports about T-matrix Riemann sheets #204

Closed
wants to merge 105 commits into from
Closed

DOC: add reports about T-matrix Riemann sheets #204

wants to merge 105 commits into from

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Sep 9, 2023 •
edited
Loading

Moved to #261

@redeboer redeboer added the 📝 Docs Improvements or additions to documentation label Sep 9, 2023
@redeboer redeboer self-assigned this Sep 9, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@redeboer redeboer assigned Zeyna777 and unassigned redeboer Sep 21, 2023
@redeboer
Copy link
Member Author

The documentation jobs have been killed due to timeout
https://readthedocs.org/projects/compwa-org/builds/22004094/
https://github.com/ComPWA/compwa-org/actions/runs/6275813340/job/17044140980?pr=204
I've tried running this PR locally as well and it seems to have to do with the combination of widgets with plotly. @Zeyna777, could you remove the widgets and keep the plotly to see if this fixes the CI? We can then see if plotly renders at all and revert to the widgets when we find the cause of the problem.

@redeboer
Copy link
Member Author

I'm wondering whether we should merge this TR into the existing TR-004, which is an investigation into analyticity that has not been finished 🤔

@redeboer redeboer self-assigned this Mar 6, 2024
@redeboer
Copy link
Member Author

@Zeyna777 the temporary notebooks have been removed. You can retrieve them from 36c1c46 with

git checkout 36c1c467

and move them somewhere else.

@redeboer redeboer marked this pull request as ready for review March 20, 2024 20:51
@Zeyna777 Zeyna777 mentioned this pull request Mar 21, 2024
Merged
@redeboer redeboer added the ⚪ Duplicate This issue or pull request already exists label Mar 21, 2024
@redeboer redeboer closed this Mar 21, 2024
@redeboer redeboer deleted the riemann-sheets branch March 21, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
📝 Docs Improvements or additions to documentation ⚪ Duplicate This issue or pull request already exists
Projects
None yet
Milestone
0.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@redeboer @Zeyna777