Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention issues: PostMessage is only sent once. Keyboard doesn't work #10047

Closed
2 tasks
juliusknorr opened this issue Sep 13, 2024 · 2 comments · Fixed by #10273
Closed
2 tasks

Mention issues: PostMessage is only sent once. Keyboard doesn't work #10047

juliusknorr opened this issue Sep 13, 2024 · 2 comments · Fixed by #10273

Comments

@juliusknorr
Copy link
Member

Describe the Bug

While working on emitting notifications for user mentions in the Nextcloud integration I noticed a couple of issues around mentions that are related to the Collabora side of the implementation.

It would be great to address those to make the mentions feature more flawless.

Steps to Reproduce

  1. Use the Nextcloud integration with Collabora
  2. Type @ to insert a mention
  3. Start typing and search for a user
  • Currently the search is only triggered once on the first character press @a. This is especially a problem for large instances with lots of users where the first result set would not contain all of the users. Instead there should be a debounced fetching of users while typing. You also see that only one postmessage is sent to Nextcloud.
  • Clicking is required to insert a mention, having one match an pressing enter does not work

Additional Context

Latest master branch of online

@timur-g
Copy link
Contributor

timur-g commented Sep 13, 2024

#7923 seems related where double @@mention may work.

@timur-g timur-g added the 24.04 label Sep 13, 2024
@pedropintosilva pedropintosilva changed the title Mention issues Mention issues: not all users are shown. Keyboard doesn't work Oct 8, 2024
@pedropintosilva pedropintosilva changed the title Mention issues: not all users are shown. Keyboard doesn't work Mention issues: PostMessage is only sent once. Keyboard doesn't work Oct 8, 2024
@Rash419
Copy link
Contributor

Rash419 commented Oct 18, 2024

https://github.com/Rash419/online/commits/debounce-mention-user-query/ I will create a PR once #10145 is merged : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants