Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: maintain backwards compatibility #995

Closed
wants to merge 4 commits into from

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Jul 11, 2024

Summary

Add backward compatibility for webhook services.

Instead of being saved in rop_data.services, they will be saved in rop_data.services_webhooks! (same thing for active accounts)

The set and get functions have been modified to ensure that pulling and saving the data are the same for the whole program, even if the data is from two different sources.

Note

THe way we merge the data is by making the webhooks always appear first in the Dashboard. If this bothers someone, the accounts can be sorted by the creation date.

Testing

Use the build from this PR together with https://github.com/Codeinwp/tweet-old-post-pro/pull/537

  1. Add a webhook.
  2. Switch to the current ROP version.
  3. No crash should happen.

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Jul 11, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 11, 2024

Plugin build for 7dab8de is ready 🛎️!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants