-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed some free features for new users #975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remove that missed console.log
. The rest is good 👌
Regarding the failing E2E, the problem is the old packages. They are updated in #974 -- As a context on why they are failing.
@girishpanchal30 what is considered a new user? Thanks! |
@rodica-andronache I've used this option to identify new users. |
@girishpanchal30 let's use the last_install_time, if the time - last_install_time is < 1h is considered new. |
@rodica-andronache @selul I've added a new option to identify new users based on the last install time. Please recheck with the latest build zip. |
@girishpanchal30 I've tried again, on a fresh instance but it doesn't work for me. The options are still there, in the free version. What else should I try? |
@rodica-andronache Can you please share your test instance details here? |
|
@rodica-andronache It seems issue with the -1 license, now it is fixed, please check with the latest commit. |
@girishpanchal30
To test what happens to an older user, I had ROP on a site, installed for more than 1h, I deleted it and installed this new version. But the features are still missing, like this would be a new user as well. Is there something I'm missing?
|
@rodica-andronache Fixed all 3 mentioned issues with the latest commit, please recheck with the newest build zip. |
@girishpanchal30 the first two issues are fixed. But the third one is still happening for me. Let me know if there's something I can do on my side |
@rodica-andronache can you follow the next testing case on a Fresh instance: Install current version of rop from wporg. Update install time to 1 day before. Download the zip from here and install it. Check if the features are preserved. The reason why is happening is because of the way you are testing by starting from the new version and rollback. |
@girishpanchal30 it works now, thank you! |
🎉 This PR is included in version 9.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
I've disabled some free features for new users only, now premium users can use those features.
Close Codeinwp/tweet-old-post-pro/issues/523