Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed some free features for new users #975

Merged
merged 9 commits into from
Jul 10, 2024
Merged

Removed some free features for new users #975

merged 9 commits into from
Jul 10, 2024

Conversation

girishpanchal30
Copy link
Contributor

I've disabled some free features for new users only, now premium users can use those features.

Close Codeinwp/tweet-old-post-pro/issues/523

@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 5, 2024

Plugin build for 84d7961 is ready 🛎️!

Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove that missed console.log. The rest is good 👌

Regarding the failing E2E, the problem is the old packages. They are updated in #974 -- As a context on why they are failing.

vue/src/vue-elements/post-format.vue Outdated Show resolved Hide resolved
@rodica-andronache
Copy link

@girishpanchal30 what is considered a new user?
I've tried on multiple newly created sites and I can't see any of the fields removed, or marked as PRO. I don't know if I'm missing something
https://vertis.d.pr/i/azFI3y

Thanks!

@girishpanchal30
Copy link
Contributor Author

@selul
Copy link
Contributor

selul commented Jul 8, 2024

@girishpanchal30 let's use the last_install_time, if the time - last_install_time is < 1h is considered new.

@girishpanchal30
Copy link
Contributor Author

@rodica-andronache @selul I've added a new option to identify new users based on the last install time. Please recheck with the latest build zip.

@rodica-andronache
Copy link

@girishpanchal30 I've tried again, on a fresh instance but it doesn't work for me. The options are still there, in the free version. What else should I try?

@girishpanchal30
Copy link
Contributor Author

@rodica-andronache Can you please share your test instance details here?

@rodica-andronache
Copy link

rodica-andronache commented Jul 9, 2024

@girishpanchal30

https://glowing-stoat-d8ecc5.vertisite.cloud/wp-admin
user: rodica
pass: g0L@K8ATFM)qXFOErEsJ6UgG

@girishpanchal30
Copy link
Contributor Author

@rodica-andronache It seems issue with the -1 license, now it is fixed, please check with the latest commit.

@rodica-andronache
Copy link

@girishpanchal30
On a fresh site ( so this is a new user ) everything worked well. There are just two things to mention:

  • for these two upsells https://vertis.d.pr/i/VNtxtY I think the text should be "Custom meta fields are only available in the Pro version" and "Custom fields are only available in the Pro version"
  • here, from what I understood from the issue, reviv.ly should be the default option. Right now, the field is empty by default https://vertis.d.pr/i/EO4M9k

To test what happens to an older user, I had ROP on a site, installed for more than 1h, I deleted it and installed this new version. But the features are still missing, like this would be a new user as well. Is there something I'm missing?
Here is the instance:

https://rop-test.vertisite.cloud/wp-admin/
user: rodica
password: sfE@sWP(Iyd7WVK$Fifwti*k

@girishpanchal30
Copy link
Contributor Author

@rodica-andronache Fixed all 3 mentioned issues with the latest commit, please recheck with the newest build zip.

@rodica-andronache
Copy link

@girishpanchal30 the first two issues are fixed. But the third one is still happening for me. Let me know if there's something I can do on my side

@selul
Copy link
Contributor

selul commented Jul 10, 2024

@rodica-andronache can you follow the next testing case on a Fresh instance:

Install current version of rop from wporg. Update install time to 1 day before. Download the zip from here and install it. Check if the features are preserved.

The reason why is happening is because of the way you are testing by starting from the new version and rollback.

@rodica-andronache
Copy link

@girishpanchal30 it works now, thank you!

@selul selul merged commit da0b9b5 into development Jul 10, 2024
5 of 6 checks passed
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 9.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants