Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest update requires PHP v7.4 #879

Closed
purplecodes opened this issue Aug 2, 2023 · 7 comments · Fixed by #880 or #881
Closed

Latest update requires PHP v7.4 #879

purplecodes opened this issue Aug 2, 2023 · 7 comments · Fixed by #880 or #881
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. regression Issue represents a change in behavior from a previous version that is not intended or desired.. released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@purplecodes
Copy link

purplecodes commented Aug 2, 2023

Description

ROP requires at least PHP v7.2 or higher and this is also displayed in wp.org. https://vertis.d.pr/i/aBd2JD

But since the last update (v9.0.15), some free users are reporting that they are getting the error below:

Fatal error: Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 7.4.0". You are running 7.3.33-10+ubuntu20.04.1+deb.sury.org+1. in /s1-suspendship/wordpress/wp-content/plugins/tweet-old-post/vendor/composer/platform_check.php on line 24
There has been a critical error on this website. Please check your site admin email inbox for instructions.

If this is the new requirement, please update the PHP version requirement on wp.org.
It would be good as well if there is a way for us to inform the users before they update as they will be locked our from their WordPress Dashboard if they have a lower PHP version than required.

Step-by-step reproduction instructions

Steps to replicate:

  1. Install and activate the Revive Old Posts plugin.
  2. If your version of PHP is lower than v7.4, you will most likely get the error stated above.

https://vertis.d.pr/i/m9Zob1

Ticket: https://wordpress.org/support/topic/latest-update-breaks-site-with-php-7-3/

Is the issue you are reporting a regression

Yes, this is a regression.

@purplecodes purplecodes added the bug This label could be used to identify issues that are caused by a defect in the product. label Aug 2, 2023
@pirate-bot pirate-bot added customer report Indicates the request came from a customer. regression Issue represents a change in behavior from a previous version that is not intended or desired.. labels Aug 2, 2023
girishpanchal30 added a commit that referenced this issue Aug 2, 2023
@girishpanchal30 girishpanchal30 linked a pull request Aug 2, 2023 that will close this issue
@girishpanchal30
Copy link
Contributor

@purplecodes Now some composer packages required 7.4 or above PHP version, we need to update the readme.txt file in wp.org
@vytisbulkevicius Can please you please update the readme file?
PR #880

@gingerbeardman
Copy link

gingerbeardman commented Aug 3, 2023

The plugin functionality didn't change, so why does requirements?

Only because of some composer packages?

It is surely possible to avoid using those things that needs 7.4? Then we could retain current compatibility.

@girishpanchal30
Copy link
Contributor

Only because of some composer packages?

Yes, abraham/twitteroauth package required a 7.4 or above PHP version.
image

Thanks

@vytisbulkevicius vytisbulkevicius linked a pull request Aug 3, 2023 that will close this issue
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 9.0.16 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 3, 2023
@vytisbulkevicius
Copy link
Contributor

@girishpanchal30, readme.txt file was updated but data on wordpress.org was not changed (related to min PHP version required).

Seems like we need to change it here also - https://github.com/Codeinwp/tweet-old-post/blob/master/tweet-old-post.php

@vytisbulkevicius
Copy link
Contributor

Ignore this, the release is done and the min PHP version appears correctly now.

@gingerbeardman
Copy link

Only because of some composer packages?

Yes, abraham/twitteroauth package required a 7.4 or above PHP version. image

Thanks

Soon this package will require PHP8

I think ROP should not be tied to such a package. There are other Twitter OAuth packages that do not require the latest PHP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. regression Issue represents a change in behavior from a previous version that is not intended or desired.. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants