Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert starter site menu items #4264

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

girishpanchal30
Copy link
Contributor

Summary

I've reverted the starter site menu items, due to the 404 pages issue with a new release.

Check before Pull Request is ready:

Closes #2823

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jul 3, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jul 3, 2024
@pirate-bot
Copy link
Collaborator

pirate-bot commented Jul 3, 2024

Plugin build for f97ec79 is ready 🛎️!

@girishpanchal30
Copy link
Contributor Author

@preda-bogdan I've removed the form block from the contact us page and added sample posts, please review my new changes when you have a moment.

@selul
Copy link
Contributor

selul commented Jul 4, 2024

@girishpanchal30 blog page is not look as it should. if you want to preview this after you install the site fresh option, go to customizer to simulate the preview.

@girishpanchal30
Copy link
Contributor Author

@selul It seems only published posts can be viewed on the blog list page. once you click the Active & Publish button it is visible properly.

I'm checking this issue, do you have an idea about how to display posts on the starter site?

@girishpanchal30
Copy link
Contributor Author

@selul It seems an issue with WP core, I found the core ticket related to this issue - https://core.trac.wordpress.org/ticket/39254

@selul
Copy link
Contributor

selul commented Jul 4, 2024

got it, in this case we can remove the posts please.

@girishpanchal30
Copy link
Contributor Author

@selul Removed

@vytisbulkevicius vytisbulkevicius merged commit 0ac99f1 into development Jul 4, 2024
15 checks passed
@vytisbulkevicius vytisbulkevicius deleted the fix/starter-site/404-pages branch July 4, 2024 11:49
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants