Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new starter site content #4258

Merged
merged 7 commits into from
Jul 2, 2024
Merged

Conversation

girishpanchal30
Copy link
Contributor

Summary

I've changed the starter site content according to the new starter site(Marketing Agency).
Issue - https://github.com/Codeinwp/neve-pro-addon/issues/2823

Check before Pull Request is ready:

Closes Codeinwp/neve-pro-addon#2823

@girishpanchal30 girishpanchal30 added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jun 26, 2024
@pirate-bot
Copy link
Collaborator

pirate-bot commented Jun 26, 2024

Plugin build for 319a6a0 is ready 🛎️!

Copy link
Contributor

@preda-bogdan preda-bogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have a small NIT with regards to the logo size, and maybe review the images that they are as optimised as possible while maintaining quality.

assets/img/starter-content/logo-agency.png Show resolved Hide resolved
Copy link
Contributor

@harshitarora-in harshitarora-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@girishpanchal30 You are not using the correct icons with the proper blob background as requested and available in Figma.

For your convenience, I have exported all the icon files in the following zip file:
Marketing Agency Icons.zip

Let me know if you have questions.

@girishpanchal30
Copy link
Contributor Author

@harshitarora-in I've updated icons from the zip, please recheck with build zip, thank you

@harshitarora-in
Copy link
Contributor

@harshitarora-in I've updated icons from the zip, please recheck with build zip, thank you

@girishpanchal30 After installing the build, I cannot see the new icons in the onboarding or even in the editor; it is still using the old ones. Please let me know if I am missing anything.

https://vertis.d.pr/i/7REj6B
https://vertis.d.pr/i/ZauLhp
https://vertis.d.pr/i/DhkZD5

Test Instance

Site name: Reflective Flock
URL: https://reflectiveflock.s2-tastewp.com
Username: harshit8121
Password: dZDob2cbZr8

@girishpanchal30
Copy link
Contributor Author

@harshitarora-in I've changed is reflected in starter content not in the starter site library.
Ref: https://tinyurl.com/3xdt467s

The starter site library is managed by the Templates Patterns Collection plugin.

@harshitarora-in
Copy link
Contributor

The starter site library is managed by the Templates Patterns Collection plugin.

@girishpanchal30 Then please make the changes in the Templates Patterns Collection repository as well because we need consistent icons everywhere.

Also, as we are currently updating the Templates Patterns Collection repo, please move the Marketing Agency starter site to the beginning.

@selul
Copy link
Contributor

selul commented Jun 27, 2024

@harshitarora-in this needs to be done on the demo API endpoint, @preda-bogdan can help with this, please suggest a position for it.

@rodica-andronache
Copy link
Contributor

@girishpanchal30 there are differences on mobile, compared to https://demosites.io/marketing-agency/?noCache=true
Screenshot on 2024-06-30 at 16-15-02
Screenshot on 2024-06-30 at 16-14-48

Screenshot on 2024-06-30 at 16-15-35
Screenshot on 2024-06-30 at 16-15-19

@girishpanchal30
Copy link
Contributor Author

Hey @rodica-andronache,

The demo site is created on the Elementor plugin and Elementor has its controls to manage the responsive.
and our starter site content is created using Gutenberg, so I think we can't make it responsive as per the demo site without using any blocks plugin like Otter Blocks plugin.

@selul @harshitarora-in If you have any suggestions or solutions please share them here, so we can fix the responsive issue as well.

Thank You

@selul
Copy link
Contributor

selul commented Jul 1, 2024

@girishpanchal30 here is the gutenberg version of it https://demosites.io/marketing-agency-gb/, is the responsiveness similar ?

@girishpanchal30
Copy link
Contributor Author

@selul Yes, I've added starter site content from this https://demosites.io/marketing-agency-gb/ demo site and it looks like same.

@harshitarora-in
Copy link
Contributor

@girishpanchal30 @selul While creating the starter site, Mihai mentioned that this is the maximum responsiveness we can achieve with the core blocks, as we are using a complex background for the hero section (which is not completely responsive for mobile devices).

cc: @rodica-andronache

@vytisbulkevicius vytisbulkevicius merged commit 13c164f into development Jul 2, 2024
15 checks passed
@vytisbulkevicius vytisbulkevicius deleted the product-marketing/2823 branch July 2, 2024 12:36
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants