Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the input type in neve_get_default_meta_value function #4065

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

cristian-ungureanu
Copy link
Contributor

@cristian-ungureanu cristian-ungureanu commented Aug 9, 2023

Summary

I've changed the function to make sure that json_decode will get the proper parameter type. This should fix user's error and prevent similar things from happening.

Note: I could not replicate the issue or see the HS ticket and I saw that the user switched to Hestia. Those changes should prevent the error from happening but I could not properly test if it solves the problem since I don't have access to the user's site.

Will affect visual aspect of the product

NO

Test instructions

  • Not much to test here as I wasn't able to replicate the issue, just a general check that post-meta defaults are working fine.

Check before Pull Request is ready:

Closes Codeinwp/neve-pro-addon#2544.

@cristian-ungureanu cristian-ungureanu added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 9, 2023
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Aug 9, 2023
@cristian-ungureanu cristian-ungureanu changed the title fix: check the input type to avoid type problems [Codeinwp/neve-pro-a… Check the input type in neve_get_default_meta_value function Aug 9, 2023
@pirate-bot
Copy link
Collaborator

Plugin build for 900d1f0 is ready 🛎️!

@irinelenache
Copy link
Contributor

@cristian-ungureanu Tested and everything's working fine regarding this PR 🚀

@cristian-ungureanu cristian-ungureanu merged commit 2afa5bb into development Aug 16, 2023
44 checks passed
@cristian-ungureanu cristian-ungureanu deleted the fix/meta-default-function branch August 16, 2023 08:51
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.6.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants