Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change item_date to convert to site timezone on import #939

Merged
merged 1 commit into from
May 30, 2024

Conversation

preda-bogdan
Copy link
Contributor

Summary

Fix item date import to respect timezone settings.
Added unit test to validate item import date based on the timezone settings.

Will affect the visual aspect of the product

NO

Screenshots

UTC

image

image

image

UTC +2

image

image

image

Test instructions

  1. On a fresh instance with Feedzy.
  2. Set the Timezone from Settings > General to a desired locale.
  3. Create a new import where we map the #item_date.
  4. Import a feed, and check that the imported items are offset correctly on import based on

Check before Pull Request is ready:

Closes #832.

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label May 13, 2024
@pirate-bot
Copy link
Contributor

Plugin build for 40acd78 is ready 🛎️!

@irinelenache
Copy link

@preda-bogdan Tested and everything's fine here ✔️

@vytisbulkevicius vytisbulkevicius merged commit 8ddf302 into development May 30, 2024
10 checks passed
@vytisbulkevicius vytisbulkevicius deleted the fix/import_timezone branch May 30, 2024 10:12
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 4.4.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants